Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added functions related to tags in testservice #64

Merged
merged 2 commits into from
Mar 12, 2017
Merged

Added functions related to tags in testservice #64

merged 2 commits into from
Mar 12, 2017

Conversation

YujiOshima
Copy link
Contributor

Added TestServer functions on api of tag shown below to testservice.

  • GET /api/1.0/tags/ op=list
  • POST /api/1.0/tags/ op=new
  • GET /api/1.0/tags/{name}/
  • GET /api/1.0/tags/{name}/ op=nodes
  • POST /api/1.0/tags/{name}/ op=update_nodes
  • PUT /api/1.0/tags/{name}/
  • DELETE /api/1.0/tags/{name}/

@YujiOshima
add Tag operation to testsetvice
7c8da28 
Signed-off-by: Yuji Oshima <yuji.oshima0x3fd@gmail.com>
@YujiOshima
fix bug in getting nodes that have specific tag
82cbb51 
Signed-off-by: Yuji Oshima <yuji.oshima0x3fd@gmail.com>
axw
axw approved these changes Mar 12, 2017
View reviewed changes
Copy link
Contributor

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you.

@axw
Copy link
Contributor

axw commented Mar 12, 2017

$$merge$$

@jujubot
Copy link
Contributor

jujubot commented Mar 12, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-gomaasapi

@jujubot jujubot merged commit 31d8415 into juju:master Mar 12, 2017
@YujiOshima YujiOshima mentioned this pull request Mar 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axw axw axw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YujiOshima @axw @jujubot