MAAS2: handle fields that might be missing or null from the API #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on schema info from the MAAS team. https://docs.google.com/a/canonical.com/spreadsheets/d/1qysFkvJwz3w19B3kYcnlokwqdTb82HGCrF4pUk6gtfA/edit?usp=sharing
Based on information from the MAAS team. https://docs.google.com/a/canonical.com/spreadsheets/d/1qysFkvJwz3w19B3kYcnlokwqdTb82HGCrF4pUk6gtfA/edit?usp=sharing
|
LGTM |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-gomaasapi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I asked the MAAS team to look through a list of all the fields that we're using in the MAAS v2 API and tell us which of them were optional or nullable. These changes are based on the information they gave us back.
Based on the spreadsheet here: https://docs.google.com/a/canonical.com/spreadsheets/d/1qysFkvJwz3w19B3kYcnlokwqdTb82HGCrF4pUk6gtfA/edit?usp=sharing