Allocate machine with interface and storage constraints #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Zone string | ||
| NotInZone []string | ||
| // Storage is an optional value listing one or more storage constraints. | ||
| // Format is an optional label, followed by an optional colon, then size |
|
LGTM. Looks much better. |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-gomaasapi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After talking with the MaaS folks, I got a better understanding of the allocation process.
In particular the mapping of storage devices and interfaces to the constraints requested.
There is a dictionary in the response structure of allocate that isn't a standard machine attribute that indicates how the machine was chosen. The keys in this dictionary are only specified when constraints of that type are specified.