Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a device #21

Merged
merged 9 commits into from
Apr 5, 2016
Merged

Create a device #21

merged 9 commits into from
Apr 5, 2016

Conversation

howbazaar
Copy link
Contributor

Based on the devices support in the controller PR #20.

func (c *controller) delete(path string) error {
path = EnsureTrailingSlash(path)
requestID := nextRequestID()
logger.Tracef("request %x: DELTE %s%s", requestID, c.client.APIURL, path)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DELETE?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@mjs
Copy link

mjs commented Apr 5, 2016

LGTM

@howbazaar
Copy link
Contributor Author

$$merge$$

@jujubot
Copy link
Contributor

jujubot commented Apr 5, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-gomaasapi

@jujubot jujubot merged commit ca0860e into juju:master Apr 5, 2016
@howbazaar howbazaar deleted the create-device branch April 5, 2016 02:25
jujubot added a commit that referenced this pull request Apr 5, 2016
Add types for interface and links.

Based on PR #21, this branch adds interfaces and links. These are needed to be able to add static IP addresses to new interfaces for container networking.

The boot interface and interface set are now also exported from Machine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants