LP-2039105: do not duplicate the oauth headers in case of retry #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
SimonRichardson
approved these changes
Oct 12, 2023
|
/merge |
This was referenced Oct 12, 2023
jujubot
added a commit
to juju/juju
that referenced
this pull request
Oct 12, 2023
#16423 This PR aims to bump the gomaasapi package so to include juju/gomaasapi#104 - [x] Code style: imports ordered, good names, simple structure, etc - [x] Comments saying why design decisions were made - [x] Go unit tests, with comments saying what you're testing - [x] [Integration tests](https://github.com/juju/juju/tree/main/tests), with comments saying what you're testing - [x] [doc.go](https://discourse.charmhub.io/t/readme-in-packages/451) added or updated in changed packages ## Links **Launchpad bug:** [https://bugs.launchpad.net/maas/+bug/2039105](https://bugs.launchpad.net/maas/+bug/2039105)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix for https://bugs.launchpad.net/maas/+bug/2039105.
The bug is that in case of retry, the oauth headers are duplicated in the requests and MAAS nginx reject the request with 400. The fix is actually to use
http.Header.Setinstead ofhttp.Header.Addin order to set or replace the "Authentication" header.