LP-2034014: retry on responses with status code equal to 409 #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
Hi @SimonRichardson , may I get a review on this one? Thank you so much! |
SimonRichardson
approved these changes
Sep 11, 2023
|
/build |
|
/merge |
1 task
jujubot
added a commit
to juju/juju
that referenced
this pull request
Sep 18, 2023
#16249 Including the fix committed with juju/gomaasapi#101 and released with v2.1.0 ## Checklist - [x] Code style: imports ordered, good names, simple structure, etc ## Bug reference https://bugs.launchpad.net/maas/+bug/2034014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to retry on MAAS responses with status code equal to 409.
In particular we observed that in some cases it is possible that the client calls MAAS endpoints in parallel and due to some MAAS internals the requests need to be remade by the clients.
Link to the original bug
Link to MAAS core merge proposal to add the
Retry-Afterheader in 409 responses