Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: gc tool never deletes delayed slices #5189

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

polyrabbit
Copy link
Contributor

ss := ss[:0] creates a new variable, so the outer for i, s := range ss never gets the new value.

Signed-off-by: Changxin Miao <miaochangxin@step.ai>
@SandyXSD SandyXSD merged commit 27eafc7 into juicedata:main Sep 25, 2024
39 checks passed
jiefenghuang pushed a commit that referenced this pull request Nov 26, 2024
Signed-off-by: Changxin Miao <miaochangxin@step.ai>
jiefenghuang pushed a commit that referenced this pull request Nov 26, 2024
Signed-off-by: Changxin Miao <miaochangxin@step.ai>
@zhoucheng361 zhoucheng361 added missed missed bug priority/high The highest priority module/gc&fsck gc&fsck labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants