Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delimiter for --custom-labels need to change #4612

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

kyungwan-nam
Copy link
Contributor

changed the delimiter to ; instead of ,

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.52%. Comparing base (307870c) to head (590e664).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4612      +/-   ##
==========================================
- Coverage   55.52%   55.52%   -0.01%     
==========================================
  Files         159      159              
  Lines       42984    42984              
==========================================
- Hits        23868    23865       -3     
- Misses      16456    16458       +2     
- Partials     2660     2661       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhijian-pro
Copy link
Contributor

@kyungwan-nam What is the reason for doing this?

@kyungwan-nam
Copy link
Contributor Author

@zhijian-pro
#4611 is the reason why It should be fixed.
Thanks!

@davies davies merged commit 004855c into juicedata:main Mar 29, 2024
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants