Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: cmd-warmup add option "check" and "evict" #4370

Merged
merged 8 commits into from
Jan 23, 2024

Conversation

jiefenghuang
Copy link
Contributor

close #4359

Signed-off-by: jiefeng <jiefeng@juicedata.io>
Signed-off-by: jiefeng <jiefeng@juicedata.io>
@jiefenghuang jiefenghuang requested a review from SandyXSD January 19, 2024 08:02
@jiefenghuang jiefenghuang self-assigned this Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 74 lines in your changes are missing coverage. Please review.

Comparison is base (a43dea7) 55.98% compared to head (02dad7e) 56.01%.
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/vfs/fill.go 60.18% 37 Missing and 6 partials ⚠️
cmd/warmup.go 57.62% 20 Missing and 5 partials ⚠️
pkg/vfs/internal.go 76.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4370      +/-   ##
==========================================
+ Coverage   55.98%   56.01%   +0.02%     
==========================================
  Files         154      154              
  Lines       39912    40066     +154     
==========================================
+ Hits        22345    22442      +97     
- Misses      15061    15109      +48     
- Partials     2506     2515       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: jiefeng <jiefeng@juicedata.io>
Signed-off-by: jiefeng <jiefeng@juicedata.io>
Signed-off-by: jiefeng <jiefeng@juicedata.io>
@jiefenghuang jiefenghuang added the kind/feature New feature or request label Jan 22, 2024
Signed-off-by: jiefeng <jiefeng@juicedata.io>
@jiefenghuang jiefenghuang marked this pull request as ready for review January 22, 2024 07:33
@jiefenghuang jiefenghuang requested review from SandyXSD and removed request for SandyXSD January 22, 2024 07:41
Signed-off-by: jiefeng <jiefeng@juicedata.io>
Signed-off-by: jiefeng <jiefeng@juicedata.io>
@SandyXSD SandyXSD merged commit 5e4d424 into juicedata:main Jan 23, 2024
26 checks passed
@jiefenghuang jiefenghuang deleted the feat/warmup-option branch January 26, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmd/warmup: support --check and --evict options
2 participants