Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Opcodes #1

Merged
merged 16 commits into from
Nov 6, 2021
Merged

New Opcodes #1

merged 16 commits into from
Nov 6, 2021

Conversation

juhu1705
Copy link
Owner

@juhu1705 juhu1705 commented Nov 5, 2021

No description provided.

@nelsbrock nelsbrock changed the title All new Opc were added and testet for now New Opcodes Nov 5, 2021
@juhu1705
Copy link
Owner Author

juhu1705 commented Nov 6, 2021

Der Fehler liegt daran, dass Rust deine Enum konstruktion in der neusten Version nicht unterstützt... Wir müssten diese also entweder ersetzten oder die Funktion seperat aktivieren (Ich weiß nicht genau wie das dann funktioniert). In einer älteren Version hat es aber ohne Fehler funktioniert

@juhu1705
Copy link
Owner Author

juhu1705 commented Nov 6, 2021

Ich habe jetzt die zuweisung der opcodes zu den enums entfernt, damit es auf den neueren rust Versionen wieder läuft. Das hat ja sowieso nichts gebracht. Schau bitte noch einmal drüber, dann können wir den merge starten und sind mit dem auslesen der Informationen erstmal fertig.

Copy link
Contributor

@nelsbrock nelsbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Lopsa" and "Hopsa": the mask should be 0x7F instead of 0xEF!
Also, please revert the dependency update!

Copy link
Contributor

@nelsbrock nelsbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@nelsbrock nelsbrock merged commit 226fdaa into main Nov 6, 2021
@juhu1705 juhu1705 deleted the untested branch November 6, 2021 14:45
@nelsbrock nelsbrock restored the untested branch November 6, 2021 14:46
@nelsbrock nelsbrock deleted the untested branch November 6, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants