Update axum to 0.6 RC #345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes the need to specify `*tail` in the SwaggerUi::new()
juhaku
reviewed
Nov 19, 2022
| routing::get(serve_swagger_ui).layer(Extension(config.clone())), | ||
| ).route( | ||
| &format!("{}*tail", swagger_ui.path), | ||
| routing::get(serve_swagger_ui).layer(Extension(config.clone())), |
There was a problem hiding this comment.
No need to .clone() here since it is the last usage, thus it can be moved.
Suggested change
| routing::get(serve_swagger_ui).layer(Extension(config.clone())), | |
| routing::get(serve_swagger_ui).layer(Extension(config)), |
juhaku
approved these changes
Nov 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably best not to merge this until 0.6 is a stable release, but review would be appreciated
BREAKING
Because of this change in axum 0.6:
... that means that we have to manually specify a second route without
*tailat the end. So I decided the most reasonable thing would be to make the user remove the*tailfrom the URL inSwaggerUi::new(). Then we can just register the two routes easily by appending*tailto the end of the second one.