Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contribution guide #10

Merged
merged 6 commits into from
Apr 12, 2021
Merged

contribution guide #10

merged 6 commits into from
Apr 12, 2021

Conversation

aaronspring
Copy link
Collaborator

@aaronspring aaronspring commented Mar 8, 2021

edit: was initial RPSS example. Then only contrib guide

after installing pangeo-data/climpred#566 and xarray-contrib/xskillscore#277

Todo:

  • North America spatial mean
  • use correct distributions for bins with alignment='same_verifs'
  • same after remove_bias
  • North America map
  • connect to cluster/client
  • get weekly verifs
  • plot rpss here

@aaronspring aaronspring changed the title rpss north america spatial mean RPSS example Mar 8, 2021
@aaronspring aaronspring changed the title RPSS example [WORK IN PROGRESS]: RPSS example Mar 8, 2021
@judithberner
Copy link
Owner

So we are working on some issues around weekly averages, which is in our court.
As we had discussed the skill is so low, that we don't take the weekly average over the daily metrics
(e.g. rmse, rps, ...), but compute the metric over weekly anomalies (e.g. can the model predict a warm week
from a cold week). So some of our input zarr-files (on NCAR machine) might not be correct.

Also - just to be clear - we want to keep lat/lon dependence in the metrics as long as possible, so that we can show maps (as you do). The lat/lon averaging is done just before making line plots of the metrics.

Once we have solved this, here are some sanity checks.
The RPSS for T2m for ECMWF week 1-2 is around 0.01 (reference to follow), so it's positive but very small. For RPS I would expect a larger number > 1.

“The approximate relationship between RPSS and correlation being such that a RPSS value of 0.1 corresponds to a correlation of about 0.44 (Tippett et al. 2010).”

@aaronspring
Copy link
Collaborator Author

So we are working on some issues around weekly averages, which is in our court.
As we had discussed the skill is so low, that we don't take the weekly average over the daily metrics
(e.g. rmse, rps, ...), but compute the metric over weekly anomalies (e.g. can the model predict a warm week
from a cold week). So some of our input zarr-files (on NCAR machine) might not be correct.

might be related to #11 says @abjaye

@aaronspring
Copy link
Collaborator Author

on capser I have a weekly verif example. skill looks different.

@aaronspring
Copy link
Collaborator Author

wasnt clever of me to overwrite parts of the rpss notebook. maybe I just merge the contributing guide then.

@judithberner
Copy link
Owner

Just to be clear: our latest notebook (with issue 11) is here:
https://github.com/judithberner/climpred_CESM1_S2S/blob/main/all_scores_rpss.ipynb

rpss.ipynb is an older version.

@aaronspring
Copy link
Collaborator Author

thanks. then I would cleanup my notebook here and overwrite the previous rpss notebook once the machine is back online

@aaronspring aaronspring self-assigned this Mar 10, 2021
@aaronspring aaronspring marked this pull request as ready for review April 12, 2021 20:47
@aaronspring aaronspring changed the title [WORK IN PROGRESS]: RPSS example contribution guide Apr 12, 2021
@aaronspring aaronspring merged commit 32b934b into judithberner:main Apr 12, 2021
@aaronspring aaronspring deleted the AS_rpss branch April 12, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants