Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add WebSocket server with multi-client support #263
base: develop
Are you sure you want to change the base?
feat: Add WebSocket server with multi-client support #263
Changes from all commits
467997d
43135ae
1b1bf73
ed77f7f
da080e7
e5fe109
12df31b
a709d58
b9b1780
c8127f7
b805575
1b4e9af
b897991
d2566f1
f9f2c80
1db7a8f
80ee316
fb9fecf
1975f75
7ba2f55
3d3bb45
b2c9293
bba43ae
f95d6ca
c6a2f92
12f7ba9
0f6ac4e
c88fbd7
eb200c2
16dbbc0
dd1ff48
e1db50d
d944e6f
f2c3144
b6d6bc6
74bd40b
c263239
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't correct. To remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-f Dockerfile
is not needed, as it will pick up the file with that name in the specified directoryThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably add a note somewhere saying that for GPU usage they need to install
nvidia-container-toolkit
.Also, is there a way to pick up the HF token from the
huggingface-cli
config? That way we avoid passing it directly and keeping it in the terminal history. This is possible when running outside docker, and we shouldn't make it mandatory, as it's an important security feature.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be moved up before the example is given
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to put the class name inline here, and to delete the definition of
pipeline_class
.Also, let's rename
pipeline_config
to justconfig
, as in all other examples in the readme.