Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests v2 #856

Merged
merged 23 commits into from
Oct 21, 2022
Merged

Integration tests v2 #856

merged 23 commits into from
Oct 21, 2022

Conversation

kradalby
Copy link
Collaborator

@kradalby kradalby commented Oct 13, 2022 •
edited
Loading

This is the beginning of reworking the integration tests into reusable components:

Goals:

  • reusability
  • consistency
  • lower barrier for contributors
  • alternative control servers to verify that our tests are correct
  • no sleep, more deterministic
  • do not need to bind local ports

These should be consider an unstable API, as the content of this PR will not work for all our current tests, but serve as a starter.

This PR is the beginning and it ports the "Ping all nodes" test.

Signed-off-by: Kristoffer Dalby kristoffer@dalby.cc

@kradalby kradalby force-pushed the integration-v2 branch 2 times, most recently from 9f4733b to 4052809 Compare October 18, 2022 09:59
kradalby added 22 commits October 18, 2022 15:37
@kradalby
tsic: Tailscale in Container abstraction
fa8b02a 
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby
Defince control server interface
308b9e7 
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby
hsic: ControlServer implementation of headscale in docker
b331e3f 
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby
Move some helper functions into dockertestutil package
f68ba75 
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby
Define a "scenario", which is a controlserver with nodes
a9c3b14 
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby
Skip integration tests on short or lack of docker
eda4321 
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby
Join test suite container to network, allowing seperate networks
f109b54 
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby
Add get ips command to scenario
25e39d9 
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby
test login with one node
b0a4ee4 
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby
Add comment about scenario test
13aa845 
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby
use variable for namespace
aef77a1 
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby
go mod tidy
84f9f60 
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby
remove the need to bind host port
c90d0dd 
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby
Add wait for peers and status to tsic
3951f39 
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby
Add tailscale versions, waiters and helpers for scenario
0db608a 
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby
Port PingAll test to new test suite
39bc6f7 
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby
Add new integration tests to ci
2bf50bc 
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby
Set better names for different integration tests
4cb7d63 
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby
golangci-lint --fix
36ad000 
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby
dont request tty
8502a0a 
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby
Fix golangcilint
12ee9bc 
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby
Fix golangcilint
6d8c18d 
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby
Only run integration tests from dir in new tests
b2bca2a 
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby kradalby marked this pull request as ready for review October 18, 2022 14:21
@kradalby kradalby requested a review from juanfont as a code owner October 18, 2022 14:21
juanfont
juanfont reviewed Oct 19, 2022
View reviewed changes
integration/tsic/tsic.go Show resolved Hide resolved
integration/control.go Show resolved Hide resolved
integration/scenario.go Show resolved Hide resolved
integration/scenario.go Show resolved Hide resolved
@juanfont juanfont merged commit 587a016 into juanfont:main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanfont juanfont juanfont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kradalby @juanfont