Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no arguments panic #855

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Fix no arguments panic #855

merged 2 commits into from
Oct 13, 2022

Conversation

donran
Copy link
Contributor

@donran donran commented Oct 13, 2022

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Fixes #848

juanfont
juanfont approved these changes Oct 13, 2022
View reviewed changes
Copy link
Owner

@juanfont juanfont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@juanfont juanfont merged commit 4dd2eef into juanfont:main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanfont juanfont juanfont approved these changes

@kradalby kradalby Awaiting requested review from kradalby kradalby is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running with no args produces panic
2 participants
@donran @juanfont