Add an embedded DERP server to Headscale #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This series of commit will be adding an embedded DERP server (and STUN) to Headscale, thus making it completely self-contained and not dependant in other infrastructure.
kradalby
reviewed
Mar 5, 2022
Websockets, in which DERP is based, requires a TLS certificate. At the same time, if we use a certificate it must be valid... otherwise Tailscale wont connect (does not have an Insecure option). So there is no option to expose insecure here
kradalby
reviewed
Mar 6, 2022
Comment on lines
+123
to
+128
| ServerEnabled bool | ||
| ServerRegionID int | ||
| ServerRegionCode string | ||
| ServerRegionName string | ||
| STUNEnabled bool | ||
| STUNAddr string |
There was a problem hiding this comment.
Can we split this into DERPServerConfig and DERPSTUNConfig ?
At some point I want to have a go at getting rid of all the manual reading of options from viper, I think it can do that...
There was a problem hiding this comment.
maybe look into using HCL struct based parsing?
|
|
||
| # If enabled, also listens in the configured address for STUN connections to help on NAT traversal | ||
| # For more details on how this works, check this great article: https://tailscale.com/blog/how-tailscale-works/ | ||
| stun: |
There was a problem hiding this comment.
We could possible call out that this is UDP, so people know what to open in firewall.
| @@ -0,0 +1,18 @@ | |||
| -----BEGIN CERTIFICATE----- | |||
There was a problem hiding this comment.
I feel like we need to know the expiry of this
integration_embedded_derp_test.go
Outdated
| ) | ||
| assert.Nil(t, err) | ||
| log.Printf("Result for %s: %s\n", hostname, result) | ||
| assert.Contains(t, result, "via DERP") |
There was a problem hiding this comment.
Can we verify the correct derp?
Co-authored-by: Kristoffer Dalby <kradalby@kradalby.no>
Co-authored-by: Kristoffer Dalby <kradalby@kradalby.no>
…into embedded-derp
|
This seems finished, but needs some linting and a changelog entry. |
…into embedded-derp
…into embedded-derp
juanfont
changed the title
kradalby
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of commits will be adding an embedded DERP server (and STUN) to Headscale,
thus making it completely self-contained and not dependent in other infrastructure.