-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PollNetMapStream: do not create any rows during long-poll operation #278
Conversation
This looks good to me. @kradalby what is your opinion? |
Yep I'm happy to have this, @enoperm do you think it is suitable for merge? |
Sorry, haven't had the time to finish up the MR the way I wanted last week. That said, I have thought a bit about it, and ultimately decided I'd rather not add a deployment test for this specific issue unless requested - the original problem looks implementation specific, and unlikely to re-emerge in the future, so long as GORM or The changes are not so large that I see it as a requirement of not breaking things, either. |
109cd5d
to
2ddea63
Compare
2ddea63
to
761147e
Compare
I seem to have messed up a bit when I first tried to merge the current |
@enoperm Do you mind fixing the |
prettier changes
raised a GitHub issue or discussed it on the projects chat beforehand- found existing issues.added unit tests- testing requires a client, currently only available in integration tests.] added integration testsneeded- PR contains changes without changes to expected behaviour towards clients or users.Fixes #232 (manually tested in the no-preauthkeys case)
Related to #93