-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix goreleaser warnings #2106
fix goreleaser warnings #2106
Conversation
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
WalkthroughThe changes to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- .goreleaser.yml (2 hunks)
Additional comments not posted (2)
.goreleaser.yml (2)
2-2
: Verify compatibility with GoReleaser version.The addition of
version: 2
at line 2 suggests a significant change in the configuration schema. It's crucial to ensure that this version is compatible with the installed GoReleaser version to avoid runtime issues.Please confirm that the GoReleaser version in use supports the
version: 2
configuration schema. This can typically be checked in the GoReleaser release notes or documentation.
188-188
: Update to version template in snapshots is appropriate.The change from
name_template
toversion_template
at line 188 correctly reflects the intended use of versioning in snapshot releases. This change should help clarify the purpose and usage of the template in defining snapshot versions.
Summary by CodeRabbit