-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oldest client supported, not latest #2086
Conversation
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
WalkthroughThe recent changes to the Headscale application include updates to the client support documentation, clarifying that the oldest supported client is version 1.42. Additionally, the requirement for at least one DERP to be defined at startup has been emphasised, alongside the need for a private key for the embedded DERP server. A line regarding multiple IP ranges in the tailnet has been removed from the README, indicating a potential change in feature support. Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- README.md (1 hunks)
Files skipped from review due to trivial changes (1)
- README.md
Additional comments not posted (3)
CHANGELOG.md (3)
32-32
: Clarification on supported client versions approved.The change to specify that "the oldest supported client is 1.42" is clear and addresses the concerns raised in the PR. This should help ensure users are aware of the minimum client version supported, rather than the maximum.
32-32
: Requirement for DERP configuration at startup approved.The clarification that at least one DERP must be defined at startup is crucial for ensuring the server operates correctly. This prevents potential runtime issues due to misconfiguration.
32-32
: Enhanced security for embedded DERP server approved.The requirement for a private key for the embedded DERP server is a positive change, enhancing the security of the server setup.
Closes #2070
Summary by CodeRabbit