Migrate IP fields in database to dedicated columns #1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes juanfont#1785 Fixes juanfont#1827 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
force-pushed
the
rework-ip
branch
3 times, most recently
from
0c54029 to
2ba1e0f
Compare
This commit migrates the list in ip_addresses column into two separate columns, ipv4 and ipv6 and puts them into dedicated types. Followup commit updates types everywhere and in tests. Updates juanfont#1828 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Updates juanfont#1828 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
force-pushed
the
rework-ip
branch
3 times, most recently
from
c9f96f8 to
1b54023
Compare
Fixes juanfont#968 Updates juanfont#1828 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Updates juanfont#614 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Fixes juanfont#614 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
juanfont
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #1828, ergonomically improving our handling of the IPv4/6 configuration and internals.
Closes #1828
Closes #1785
Closes #1827
Closes #614
Closes #968