Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MagicDNS base domain #174

Merged
merged 7 commits into from
Oct 18, 2021
Merged

Fix MagicDNS base domain #174

merged 7 commits into from
Oct 18, 2021

Conversation

juanfont
Copy link
Owner

This PR fixes #160, by only including as routed DNS domains those of the namespaces handled by Headscale.

It also improves the way tailscale status reports the namespaces of the shared machines by sending the correct list of tailcfg.UserProfile.

Also, some code cleanup.

@juanfont juanfont requested review from kradalby and cure October 17, 2021 10:12
dns.go Show resolved Hide resolved
api.go Outdated Show resolved Hide resolved
@juanfont juanfont merged commit 10d24e6 into main Oct 18, 2021
@juanfont juanfont deleted the fix-magic-dns-base-domain branch October 18, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MagicDNS base domain clobbers valid records
2 participants