Simplify update logic #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is some weird behaviour that seem to storm the update channel. And our solution with a central map of update channels isnt particularly elegant. For now, replace all the complicated stuff with a simple channel that checks roughly every 10s if the node is up to date. Only generate and update if there has been changes.
Closed
|
Fixes #97 |
juanfont
reviewed
Oct 6, 2021
juanfont
reviewed
Oct 6, 2021
| } | ||
| } | ||
| h.setLastStateChangeToNow(ns.Name) |
There was a problem hiding this comment.
Is this enough for the shared nodes? This does not trigger an update to the namespaces where this node is shares...
There was a problem hiding this comment.
Good point, I believe I have addressed it in the last commit.
juanfont
reviewed
Oct 7, 2021
| @@ -10,6 +10,7 @@ require ( | |||
| github.com/docker/cli v20.10.8+incompatible // indirect | |||
| github.com/docker/docker v20.10.8+incompatible // indirect | |||
| github.com/efekarakus/termcolor v1.0.1 | |||
| github.com/fatih/set v0.2.1 // indirect | |||
juanfont
reviewed
Oct 7, 2021
juanfont
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the update channel logic and tears out all the complicated (and extremely flaky) channel map trying to keep track of all the clients.
Instead of trying to manage notifies across the app, we will now check every 10s if a given client is up to date. If it is out of date and still has an open update channel, then generate and send an update.
This isn't the most elegant solution, but should work better than the current solution and address #97.
I will try to work on improving the "am I out of date" checks in the future.
Would appreciate if someone will help test this from the branch or from master before release. @busimus @jsiebens