-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added version checker on Headscale startup #128
Conversation
Would it be possible to add a config option to disable this? At least in OpenBSD ports land it's typical that these kind of checks are disabled so as not to cause confusion for people that installed it via The alternative would be that I have to carry patches in the OpenBSD port to disable the check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually @qbit has a good point.
Also having something call the internet is not optimal without being able to disable it.
How does that library handle lack of internet?
That makes sense to me, I do still think it would be good to have an option to completely disable it for people that don't want to tell github what software they are running. |
No OS checks, those operating systems also have package managers. It should be possible to turn off for all package maintainers |
Famous last words 😂😂 Indeed, those OS might end up having Headscale packages. We leave it then as a viper config setting (via the |
LGTM! |
This small PR just adds an updated version checker on startup.
It uses https://github.com/tcnksm/go-latest to fetch the latest release in GitHub.