oidc: allow reading the client secret from a file #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motiejus
force-pushed
the
oidc-client-secret-file
branch
from
3e7efed to
e08b711
Compare
kradalby
reviewed
Jan 11, 2023
motiejus
force-pushed
the
oidc-client-secret-file
branch
from
e08b711 to
f9f9268
Compare
|
Updated the PR as per @kradalby 's comments. I was able to reproduce the integration test failure locally and will investigate it over the next couple of days. |
motiejus
force-pushed
the
oidc-client-secret-file
branch
from
f9f9268 to
3318f8b
Compare
|
I've updated the test and it passed locally. |
motiejus
force-pushed
the
oidc-client-secret-file
branch
from
3318f8b to
d6b985d
Compare
|
Apologies for missing to check the linter. Fixed a linter error. |
Currently the most "secret" way to specify the oidc client secret is via an environment variable `OIDC_CLIENT_SECRET`, which is problematic[1]. Lets allow reading oidc client secret from a file. For extra convenience the path to the secret will resolve the environment variables. [1]: https://systemd.io/CREDENTIALS/
juanfont
force-pushed
the
oidc-client-secret-file
branch
from
d6b985d to
d57b3b0
Compare
kradalby
approved these changes
Jan 14, 2023
2 tasks
|
FYI the subsequent change to nixpkgs: NixOS/nixpkgs#217482 |
motiejus
added a commit
to motiejus/nixpkgs
that referenced
this pull request
Mar 8, 2023
Headscale now supports passing the OIDC client secret via a file, as added in [juanfont/headscale#1127][1127]. Lets use that. The headscale option is `client_secret_path`; let's make it consistent and rename the Nix option to this. Note that I wasn't able to do this: mkRenamedOptionModule [ ... "client_secret_file" ] [ ... "client_secret_path" ] I get such error: error: evaluation aborted with the following error message: 'cannot find attribute `services.headscale.settings.oidc.client_secret_file'' [1127]: juanfont/headscale#1127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the most "secret" way to specify the oidc client secret is via an environment variable
OIDC_CLIENT_SECRET, which is problematic1. Lets allow reading oidc client secret from a file. For extra convenience the path to the secret will resolve the environment variables.