Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid json when deleting nodes with -o flag #152

Closed
0xcd0e opened this issue Oct 12, 2021 · 2 comments · Fixed by #155
Closed

Invalid json when deleting nodes with -o flag #152

0xcd0e opened this issue Oct 12, 2021 · 2 comments · Fixed by #155

Comments

@0xcd0e
Copy link

0xcd0e commented Oct 12, 2021

When deleting a node while using the -o json parameter, the value returned is not valid json:

# headscale nodes -n testns delete 1 -o json-line
? Do you want to remove the node ts-client? Yes
Node deleted

Tested on v0.10.1
juanfont added a commit that referenced this issue Oct 12, 2021
@juanfont
Output json when deleting node (fixes #152)
6924b7b
@juanfont juanfont mentioned this issue Oct 12, 2021
Merged
@juanfont
Copy link
Owner

Fixed! Will come in the next minor release

@0xcd0e
Copy link
Author

0xcd0e commented Oct 14, 2021

Thank you for implementing this so fast :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add JSON output when deleting node juanfont/headscale
2 participants
@juanfont @0xcd0e