Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accessibility mode and respect FOV effect scale for FOV effects #88

Merged
merged 7 commits into from
Jan 29, 2023

Conversation

bl4ckscor3
Copy link
Contributor

This PR focuses on accessibility related features. It adds a new accessibility mode to the settings, which, when turned on, will disable certain events that may contain flashing, jittery, or potentially nauseating images. Find a list of these events below. If you think any could be added, do let me know. This setting is independent on server and client, however if a server has it enabled, no players will receive these events no matter if they have accessibility mode on or not.
If a server has accessibility mode disabled, and sends affected events to players that have the mode enabled, the event will not be played and display crossed out in the event list. Example image:

The events configuration screen does not reflect this setting, and there is no notice next to affected events. I thought about adding it, but since the screen does not have access to an event instance, I didn't. For this to be properly implemented, a new event instance of each event would need to be created when this screen is opened. If you have no problem with that, I can go ahead and add that.
Accessibility mode also stops rendering the fire overlay for the fire trail event, since the overlay is flickering when running during this event. https://i.imgur.com/mWy7kcv.mp4

Another addition this PR makes is respecting the "FOV Effects" slider for all events affecting the FOV.

The following events are disabled if accessibility mode is enabled:

  • LagEvent
  • LowFPSEvent
  • LSDEvent
  • RandomCameraTiltEvent
  • RollingCameraEvent
  • StutteringEvent
  • UpsideDownEvent

@juancarloscp52
Copy link
Owner

Thank you so much for this feature! It is something that I've been wanting to do but I haven't had the time :/

For this to be properly implemented, a new event instance of each event would need to be created when this screen is opened. If you have no problem with that, I can go ahead and add that.

Yeah it is not a problem feel free to instantiate events in that screen.

@bl4ckscor3
Copy link
Contributor Author

This has now been implemented! Accessibility mode automatically disables the checkboxes in the event configuration screen, and prevents players from reenabling them. This means that the events disabled by accessibility mode will be written to the config file, which is contrary to the initial behavior. If accessibility mode is disabled, the events will not automatically be reenabled. If a user hovers over the list entry of an affected event, they will see a tooltip.

@juancarloscp52 juancarloscp52 merged commit c7e1f0a into juancarloscp52:1.19.3 Jan 29, 2023
@bl4ckscor3 bl4ckscor3 deleted the accessibility-mode branch January 29, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants