Add MLG bucket event #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/me/juancarloscp52/entropy/events/EventRegistry.java # src/main/resources/assets/entropy/lang/de_at.json # src/main/resources/assets/entropy/lang/de_ch.json # src/main/resources/assets/entropy/lang/de_de.json # src/main/resources/assets/entropy/lang/en_gb.json # src/main/resources/assets/entropy/lang/en_us.json # src/main/resources/assets/entropy/lang/es_ar.json # src/main/resources/assets/entropy/lang/es_cl.json # src/main/resources/assets/entropy/lang/es_ec.json # src/main/resources/assets/entropy/lang/es_es.json # src/main/resources/assets/entropy/lang/es_mx.json # src/main/resources/assets/entropy/lang/es_uy.json # src/main/resources/assets/entropy/lang/es_ve.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This event automatically places water below each player's feet if there is space. It's very useful for falling from great distances, and very annoying when jumping or just dropping down one block.
The event is being ticked on both sides, so that the MLG water bucket is consistently achieved (client), and other players can see the placed water (server). If the event would only tick on the server, there may not be enough time for the water to appear client side, thus failing the MLG water bucket.
Water placed by this event is automatically removed each second, and once the event ends.
EDIT: Just had the idea to also add an MLG lava bucket event (would place lava instead of water). Unsure about it, since it could be too similar to the already existing place lava event. Sounds fun nonetheless? It may need quicker removing of the lava to make it harder to die from that.