Fix events not respecting feature flags #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Totally forgot about that while porting to 1.19.3 hahah |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minecraft 1.19.3 added feature flags, which control whether an item, entity, etc. shows up in game. They are currently used to enable or disable content from the experimental datapacks for bundles and 1.20.
As an example to explain the issue that this PR fixes: If the update_1_20 datapack is not enabled, Entropy will, for instance during the random drops event, still drop items that are part of that datapack (the bamboo blocks are one example). With the changes from this PR, those experimental items will only drop when the corresponding experimental datapack is enabled.