Drkey feature pr7 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented RPC interface to serve Lvl2Key request to scionD. - Implemented Fetcher to fetch Lvl2Key from local CS. - Added ClientStore which encompases the logic to handle DRKeyLvl2 feature. - Added UTs.
juagargi
requested changes
Nov 2, 2020
There was a problem hiding this comment.
Reviewed 32 of 32 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @JordiSubira)
go/pkg/cs/drkey/grpc/lvl1_exchange_test.go, line 117 at r1 (raw file):
req, err := dk_grpc.Lvl1reqToProtoRequest(lvl1req) require.NoError(t, err) _, err = client.DRKeyLvl1(context.Background(), req)
I get an error here when I run the test:
==================== Test output for //go/pkg/cs/drkey/grpc:go_default_test:
--- FAIL: TestLvl1KeyFetching (0.01s)
lvl1_exchange_test.go:118:
Error Trace: lvl1_exchange_test.go:118
Error: Received unexpected error:
rpc error: code = Unavailable desc = connection error: desc = "transport: authentication handshake failed: verifying connection in client handshake\n extracting IA from server name\n Invalid ISD-AS raw=\"\""
Test: TestLvl1KeyFetching
panic.go:563: missing call(s) to *mock_drkeystorage.MockServiceStore.DeriveLvl1(is anything, is anything) go/pkg/cs/drkey/grpc/lvl1_exchange_test.go:77
panic.go:563: aborting test due to missing call(s)
FAIL
================================================================================
But I don't really know where it stems from.
juagargi
approved these changes
Nov 2, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @JordiSubira)
JordiSubira
added a commit
that referenced
this pull request
Nov 5, 2020
* move DRKey requests/responses to their own package * add protobuf DRKey RPC in sciond * added DRKey feature to go/pkg/sciond package: - Implemented RPC interface to serve Lvl2Key request to scionD. - Implemented Fetcher to fetch Lvl2Key from local CS. - Added ClientStore which encompases the logic to handle DRKeyLvl2 feature. - Added UTs. * fixing lint errors * fixing error with serverName in transport_credentials
juagargi
pushed a commit
that referenced
this pull request
Dec 10, 2020
* move DRKey requests/responses to their own package * add protobuf DRKey RPC in sciond * added DRKey feature to go/pkg/sciond package: - Implemented RPC interface to serve Lvl2Key request to scionD. - Implemented Fetcher to fetch Lvl2Key from local CS. - Added ClientStore which encompases the logic to handle DRKeyLvl2 feature. - Added UTs. * fixing lint errors * fixing error with serverName in transport_credentials
juagargi
added a commit
that referenced
this pull request
Jan 4, 2021
* Drkey feature PR1 (#3) * lib drkey files * Epoch based on Validity period https://github.com/scionproto/scion/pull/2842/files * added test for secret value derivation * embed Validity in Epoch * Replacing RawBytes by byte slice, using xtest to parse hex string suite.go moved out to package exchange Added Equal to DRkey added dep in BUILD.bazel * add bazel for exchange pkg * Drkey feature PR2 (#4) * lib drkey protocol files * adding AS->Host, Host->Host to standard UI + minor changes * Replacing RawBytes by byte slice * Added suite.go UT * mending protocol BUILD.bazel * using testify in suite.go UT * refactoring testify protocol_test.go * Drkey feature PR3 (#5) * Initial commit lib drkey drkeysqlite files * refactor to Epoch based on Validity * minor changes out of revision * refactoring db_test with testify * Drkey port pr4 (#7) * proto/sciond.capnp added drkey data + proto/drkey_mgmt.capnp + auto-generated files + inital go/lib/ctrl/drkey_mgmnt * adapted lvl2_rep to Epoch based Validity * replaced RawBytes by byte slice replaced some missed RawBytes * Use scrpyto.Version in Lvl1Rep.CrtVerDst * added drkey in ctrl/union.go * solving some golint warning in drkey_mgmt * replacing RawBytes in Lvl2req * Drkey port pr5 (#11) * inital commit drkeystorage pkg * testify refactoring config_test.go * Drkey feature pr6 (#19) * cppki validity refactoring * Drkey protobuf * changes in drkeystorage: - Modified ServiceStore interface - Added mock * added DRKey cp requests * Added package go/pkg/cs/drkey: - ServiceStore adapted to use new Fetcher - Prefetcher and SecretValueStore * Added ValitadePeerWithCert function: - This function might help validating authentication information from peer in DRKey exchanges. * added package go/pkg/cs/drkey/grpc: - DRKeyService which handles both Lvl1 and Lvl2 request. - DRKeyFetcher which fetches Lvl1 keys from some remote CS. * added drkey CS config: - added DRKey and DRKeyDB configuration files * Refactoring drkey protobuf * trust: added ClientTransportCredentials: ClientTransportCredentials is used as a wrapper around TLS credentials so that the certificate and server name can be check within the grpc dialing. - Lvl1KeyFetching test is adapted to use ClientTransportCredentials. * mending test to pass * small fixings and explicit implements * refactoring pkg/cs UT * protobuf: Refactoring protobuf Lvl1Response and added UTo * added test inner function to prefectch keys + fixing error checking in drkey_service * deleting unnecessary callOption in drkey_fetcher * improving tests * fixing lint errors * Drkey feature pr7 (#20) * move DRKey requests/responses to their own package * add protobuf DRKey RPC in sciond * added DRKey feature to go/pkg/sciond package: - Implemented RPC interface to serve Lvl2Key request to scionD. - Implemented Fetcher to fetch Lvl2Key from local CS. - Added ClientStore which encompases the logic to handle DRKeyLvl2 feature. - Added UTs. * fixing lint errors * fixing error with serverName in transport_credentials * fixing bugs in drkey fetchers * DRKey feature pr8 (#21) * fix bug in Lvl2reqToProtoRequest * add go/lib/sciond * fixing serverName handling in verifyConnection * fixing validateLvl2Req * fixing concurrency in prefetcher * fixing log messages and config in go/pkg/sciond * added TLSQUIC stack in go/lib/infra/: - QUICStack in infraenv.go is modified so that it also returns a separate QUIC stack. - Added TLSQUICDialer which redirects requests to the TLSQUIC stack. - Added new svc transport. * plugging in DRKey in scionD and CS * fixing lint and tests * added sciond mock * remove exchange suite * remove capnp drkey from go/lib/ctrl * minor changes in cs.go and drkey config * moving out aux code from cs.go to trustlib + minor changes * fixed comment Co-authored-by: JordiSubira <jordi.subira.nieto@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes basic functionalities for the DRKey feautre in the scionD, among them:
ClientStore which encompasses the logic and persistance for DRKey within the scionD.
Lvl2Fetcher using the gRPC stack introduced in scionproto#3862
DRKey RPC handler which also uses the new gRPC stack and handles request to the scionD.
This change is