hooks: rewrite so dct initializes from hooks #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoppins
force-pushed
the
feature-hooks-rewrite
branch
3 times, most recently
from
acc6d26
to
eb4b182
Compare
jtoppins
force-pushed
the
feature-hooks-rewrite
branch
5 times, most recently
from
d653c55
to
f72a743
Compare
It seems DCS has several bugs where scripts in the .miz might be run by the client. To fix this remove the requirement to have mission designers apply the `dct-mission-init.lua` script as a do-script-from-file mission start trigger. It is expected only servers will have the hooks installed and so this should avoid the client side issues. As part of the rewrite the dct hooks dropped support for exporting data about the server. There are several other third-party server monitoring tools/hooks out there that provide far greater capability than the dct hook could provide.
Mission designers are layering other scripts on top of DCT. This means there initialization needs to be completed before players should be allowed to join slots. To allow for this use case, a well known mission flag can be used. The DCT hooks script will then use this flag to determine if hooks are globally enabled or not. Finally a server level configuration can be set to initially set this flag true/false. With the default being true so DCT will enable slots as normal as soon as it is ready.
DCT is being used as a base for some mission designers and then they are building on top of DCT by layering on other scripts like MOOSE to customize their mission. To allow sequencing of these other scripts emit an init complete event for all event handlers in the DCS mission environment so that proper sequencing can take place.
jtoppins
force-pushed
the
feature-hooks-rewrite
branch
from
f72a743
to
a7cd78f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems DCS has several bugs where scripts in the .miz might be run by the client. To fix this remove the requirement to have mission designers apply the
dct-mission-init.luascript as a do-script-from-file mission start trigger. It is expected only servers will have the hooks installed and so this should avoid the client side issues.As part of the rewrite the dct hooks dropped support for exporting data about the server. There are several other third-party server monitoring tools/hooks out there that provide far greater capability than the dct hook could provide.