This repository has been archived by the owner on Jul 30, 2022. It is now read-only.
Fixing issue with annoying "->" in top bar. #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my use of Foreground, I don't need the left dropdown menu in the top bar. Disabling it revealed a bug in which an annoying "->" appears in the top bar. It is caused by a missing "</li>" tag and unbalanced PHP curly brackets. This change fixes the problem.
|
Great catch! Thanks for the PR. Merging it. |
Hutchy68
added a commit
that referenced
this pull request
Jan 16, 2020
* Merging in changes to address issues and compatability, see CHANGELOG.md * Set version to 2.2.1dev for develop branch * More changes to CSS for issue #342 * Fix license visibility on GitHub * Duh, need License in top line too * Fixing extra bracket in CSS and moving some code to select attribute * Fix for issue #345 and other improvements, notes in CHANGELOG.md * Fixed issue with annoying "->" in top bar. (#350) In my use of Foreground, I don't need the left dropdown menu in the top bar. Disabling it revealed a bug in which an annoying "->" appears in the top bar. It is caused by a missing "</li>" tag and unbalanced PHP curly brackets. This change fixes the problem. * Bump version for bug fix * Prep for Version Release (#351) * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Bump version for bug fix * Replace usge of long deprecated and removed wfSuppressWarnings and wfRestoreWarnings (#352) * Replace usge of long deprecated and removed wfSuppressWarnings * Update Foreground.skin.php * Update Foreground.skin.php Thanks @paladox * Prep for Version Bump, merge to master for release Co-authored-by: Kai Özer <robo-fish@users.noreply.github.com> Co-authored-by: paladox <paladox@users.noreply.github.com>
Hutchy68
added a commit
that referenced
this pull request
Jan 18, 2020
* Merging in changes to address issues and compatability, see CHANGELOG.md * Set version to 2.2.1dev for develop branch * More changes to CSS for issue #342 * Fix license visibility on GitHub * Duh, need License in top line too * Fixing extra bracket in CSS and moving some code to select attribute * Fix for issue #345 and other improvements, notes in CHANGELOG.md * Fixed issue with annoying "->" in top bar. (#350) In my use of Foreground, I don't need the left dropdown menu in the top bar. Disabling it revealed a bug in which an annoying "->" appears in the top bar. It is caused by a missing "</li>" tag and unbalanced PHP curly brackets. This change fixes the problem. * Bump version for bug fix * Prep for Version Release (#351) * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Bump version for bug fix * Replace usge of long deprecated and removed wfSuppressWarnings and wfRestoreWarnings (#352) * Replace usge of long deprecated and removed wfSuppressWarnings * Update Foreground.skin.php * Update Foreground.skin.php Thanks @paladox * Prep for Version Bump, merge to master for release * Reset version to 2.2.3dev * Dev updates with Localization (#355) * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Localisation updates from https://translatewiki.net. * Bump version for bug fix * Prep for Version Bump, merge to master for release * Reset version to 2.2.3dev Co-authored-by: translatewiki.net <l10n-bot@translatewiki.net> * Revert " Replace usge of long deprecated and removed wfSuppressWarnings and wfRestoreWarnings (#352)" This reverts commit fff0786. * Prep for release 2.2.4 Co-authored-by: Kai Özer <robo-fish@users.noreply.github.com> Co-authored-by: paladox <paladox@users.noreply.github.com> Co-authored-by: translatewiki.net <l10n-bot@translatewiki.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there. Thank you for Foreground.
In my use of Foreground, I don't need the left dropdown menu in the top bar. Disabling it revealed a bug in which an annoying "->" appears in the top bar. It is caused by a missing
</li>tag and unbalanced PHP curly brackets. This change fixes the problem.