feat(config): add auto saving on app exit #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtheoof
requested changes
Apr 7, 2024
| @@ -246,7 +246,7 @@ static void save_state_to_file_or_folder(struct swappy_state *state, | |||
| } | |||
|
|
|||
| static void maybe_save_output_file(struct swappy_state *state) { | |||
| if (state->output_file != NULL) { | |||
| if (state->config->auto_save) { | |||
There was a problem hiding this comment.
Suggested change
| if (state->config->auto_save) { | |
| if (state->config->auto_save && state->output_file != NULL) { |
There was a problem hiding this comment.
I dont think we need to check NULL for state->output_file here, as in case output_file=NULL, in save_state_to_file_or_folder the file name is generated.
Actually, with the NULL check, at least in my case, the file is not auto saved.
I'm using swappy in sway using the command as specified in the README:
grim -g "$(slurp)" - | swappy -f -every time I make a screenshot, then I close the swappy, the filename is NULL so the picture is not saved.
jtheoof
changed the title
jtheoof
reviewed
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.