Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Use *-symbolic variant of toolbar icons #139

Merged
merged 1 commit into from
Nov 20, 2022
Merged

fix(ui): Use *-symbolic variant of toolbar icons #139

merged 1 commit into from
Nov 20, 2022

Conversation

moetayuko
Copy link
Contributor

The non-symbolic variant might be indistinguishable from the background.

Fixes #34
Ref: https://wiki.gnome.org/Design/OS/SymbolicIcons

Before

GTK_THEME=Materia swappy -f foo.png:

image

GTK_THEME=Materia-light swappy -f foo.png:
image

GTK_THEME=Materia-dark swappy -f foo.png:
image

After

GTK_THEME=Materia swappy -f foo.png:

image

GTK_THEME=Materia-light swappy -f foo.png:

image

GTK_THEME=Materia-dark swappy -f foo.png:

image

@jtheoof
Copy link
Owner

jtheoof commented Nov 19, 2022

Interestingly I don't have the problem without the patch, but multiple people have reported the issue. I think the patch makes sense.

@moetayuko Can you just fix the commit message, commitlint complains about the use of Capital "Use" instead of "use". Sorry it's a bit intense, but for good reasons. :)

@jtheoof jtheoof self-assigned this Nov 19, 2022
The non-symbolic variant might be indistinguishable from the background.

Fixes #34
Ref: https://wiki.gnome.org/Design/OS/SymbolicIcons
@moetayuko
Copy link
Contributor Author

Interestingly I don't have the problem without the patch, but multiple people have reported the issue. I think the patch makes sense.

Dunno, might be relevant to the gtk theme and icon theme in use.

@moetayuko Can you just fix the commit message, commitlint complains about the use of Capital "Use" instead of "use". Sorry it's a bit intense, but for good reasons. :)

Should be fine now.

@jtheoof jtheoof merged commit 5dc44f8 into jtheoof:master Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad visuals when on dark-mode system
2 participants