Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer prints to stdout #8

Closed
Biont opened this issue Feb 19, 2020 · 4 comments · Fixed by #9
Closed

No longer prints to stdout #8

Biont opened this issue Feb 19, 2020 · 4 comments · Fixed by #9

Comments

@Biont
Copy link

Biont commented Feb 19, 2020

The command chain grim -g "$(slurp)" - | swappy -f - -o - no longer produces any output for me.
I believe this started today, so maybe something in 320dae0 broke it?

Saving pictures regularly seems to be unaffected

@jtheoof
Copy link
Owner

jtheoof commented Feb 19, 2020

OK I'll revert @pathetic-lynx patch until I understand a little bit more the issue.

@jtheoof
Copy link
Owner

jtheoof commented Feb 19, 2020

@Biont quick question for you, how do you exit swappy? Do you use the Escape or q key? Temporary fix after the commit you mentioned would be to use a Compositor window killer until I have a better fix. Example in sway $mod+q (by default). Let me know if that helps.

@pathetic-lynx
Copy link

pathetic-lynx commented Feb 19, 2020

Cannot reproduce, output to stdout when killing swappy using sway does not work in either 196f7f4 or 320dae0, killing with q works in both.

@Biont can you investigate more?

edit: does not matter whether you use grim to get the screenshot or swappy directly, same behaviour

edit2: Ok, we need to make sure that the application takes the same path when killed externally and when exiting from the keyevent with the same precondition. Currently swappy does not save the file when I hit q but it does when I kill it.

@Biont
Copy link
Author

Biont commented Feb 19, 2020

So I usually Escape out of swappy, but hitting q does not seem to make a difference.

EDIT: And yes, closing the window via my sway keybinding serves as a workaround. Thanks for the hint.

jtheoof added a commit that referenced this issue Feb 21, 2020
The bug was introduced by `f3e5d86`.

Closes #8
jtheoof added a commit that referenced this issue Feb 21, 2020
The bug was introduced by `f3e5d86`.

Closes #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants