Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text tool does not support UTF-8 properly #43

Closed
MaxVerevkin opened this issue Jun 25, 2020 · 4 comments · Fixed by #49
Closed

Text tool does not support UTF-8 properly #43

MaxVerevkin opened this issue Jun 25, 2020 · 4 comments · Fixed by #49
Labels
bug Something isn't working

Comments

@MaxVerevkin
Copy link
Contributor

Currently, swappy supports only ASCII. Unicode input (tested on ru layout) looks like that:
image
@jtheoof
Copy link
Owner

jtheoof commented Jun 26, 2020

Just to confirm, you mean using the Text painting tool right?

@MaxVerevkin
Copy link
Contributor Author

@jtheoof Yes

@jtheoof jtheoof added the bug Something isn't working label Jun 29, 2020
jtheoof added a commit that referenced this issue Jul 6, 2020
@jtheoof
fix(text): properly handle utf-8 chars
d8550b2 
UTF-8 characters are now handled porperly. Also re-worked some helper
functions with UTF-8 in mind.

Closes #43
@jtheoof jtheoof changed the title Unicode support Text tool does not support UTF-8 properly Jul 8, 2020
jtheoof added a commit that referenced this issue Jul 9, 2020
@jtheoof
fix(text): properly handle utf-8 chars
2c59fd9 
UTF-8 characters are now handled porperly. Also re-worked some helper
functions with UTF-8 in mind.

I secretly no real C developers will look at this. I might have to ask
for witness protection.

Closes #43
@jtheoof jtheoof mentioned this issue Jul 9, 2020
Merged
jtheoof added a commit that referenced this issue Jul 9, 2020
@jtheoof
fix(text): properly handle utf-8 chars
a868c7a 
UTF-8 characters are now handled porperly. Also re-worked some helper
functions with UTF-8 in mind.

I secretly no real C developers will look at this. I might have to ask
for witness protection.

Closes #43
jtheoof added a commit that referenced this issue Jul 9, 2020
@jtheoof
fix(text): properly handle utf-8 chars
717ab0c 
UTF-8 characters are now handled porperly. Also re-worked some helper
functions with UTF-8 in mind.

I secretly no real C developers will look at this. I might have to ask
for witness protection.

Closes #43
@jtheoof
Copy link
Owner

jtheoof commented Jul 9, 2020

Hello @MaxVerevkin, do you mind trying out the latest swappy-git (if you're on Arch)? It should now work for regular UTF-8 keys on your keyboard. The compose key won't work (not sure how to handle that porperly with GTK events), but at least it should be a much more pleasant experience for non ASCII keyboards :)

@MaxVerevkin
Copy link
Contributor Author

@jtheoof Yes, now it works! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(text): properly handle utf-8 chars jtheoof/swappy
2 participants
@jtheoof @MaxVerevkin