Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Solid rectangular box #120

Closed
CodedBinary opened this issue Sep 26, 2021 · 3 comments · Fixed by #136
Closed

[Feature Request] Solid rectangular box #120

CodedBinary opened this issue Sep 26, 2021 · 3 comments · Fixed by #136

Comments

@CodedBinary
Copy link

It would be nice to be able to draw a solid rectangular box. For example, redacting text with blur is insecure, so being able to use a solid box would make it much easier to quickly send images with sensitive content.

@apiraino
Copy link
Contributor

@CodedBinary just out of curiosity, what is insecure about this blur?
grafik

If you're worried about an attack that can reverse the blur, one workaround could be to give more passes with blur and make the text completely unrecoverable

@CodedBinary
Copy link
Author

@apiraino Yes, I am worried about attacks that can reverse the blur. How many passes are required to make the text unrecoverable? It isn't really clear to me when this will have occurred, because even if to the human eye something looks like a grey mush, a computer might see there is only one text string that could have resulted in that particular grey mush. And as a human I'm not sure when this is no longer possible.

I typically just use the pen on the highest width setting to draw over the text, but this is obviously messy, and doesn't leave behind nice straight boxes like the rectangle and blur tools do.

Is this kind of concern out of scope?

@apiraino
Copy link
Contributor

If I had to blur really sensitive data, I wouldn't use swappy in the first place, simply because it does not make any claims about being a privacy tool :)

I am not familiar with tecniques to reverse blurs but the implementation in swappy is here (with a handy link to the original Cairo implementation). If you're curious you can investigate how resistant to attacks could be (an interesting topic on its own)

jtheoof pushed a commit that referenced this issue Nov 18, 2022
This adds an option on top of existing brush types, to allow for filled
shapes in addition to non-filled ones.

Signed-off-by: flow <flowlnlnln@gmail.com>

Closes #120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants