Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for defining file output #1

Closed
scyt opened this issue Jan 6, 2020 · 5 comments · Fixed by #3
Closed

Add support for defining file output #1

scyt opened this issue Jan 6, 2020 · 5 comments · Fixed by #3
Assignees
@jtheoof

Comments

@scyt
Copy link

scyt commented Jan 6, 2020

I prefer to store screenshots in a specific directory that isn't $XDG_CONFIG_HOME/Desktop. Can you add support for specifying an output dir and filename on save?

Related, can the output be sent back to stdout so I can send it to something like pngquant? My current workflow involves sending from grim to pngquant, and I'd like to insert swappy in between so I can annotate the screenshots before sending them back to stdout.
@Biont
Copy link

Biont commented Jan 6, 2020

Same here. I was immediately greeted with a ** (process:88547): CRITICAL **: 20:53:32.916: could not find a valid pictures path in your env variables when I tested it out, hoping I could just throw this into my screengrabbing pipe chain for easy and effortless on-the-fly editing - something I've been searching for quite a while. This would be a very welcome addition.

@jtheoof
Copy link
Owner

jtheoof commented Jan 7, 2020

Thanks for the feedback guys, I'll separate this issue into two:

  • Have some basic configs like the output dir and the font configurable in the same vein as:  mako
  • Add ability to output the final swappy surface to stdout for more piping love.

I'll get to it over the weekend.

@jtheoof jtheoof self-assigned this Jan 7, 2020
@jtheoof jtheoof mentioned this issue Jan 12, 2020
Closed
jtheoof added a commit that referenced this issue Jan 13, 2020
@jtheoof
feat(config): have overridable defaults
df13b72 
Defaults:

 - `save_dir`
 - `stroke_size`
 - `text_font`
 - `text_size`

Closes #1
jtheoof added a commit that referenced this issue Jan 13, 2020
@jtheoof
feat(config): have overridable defaults
ec23a03 
Defaults:

 - `save_dir`
 - `stroke_size`
 - `text_font`
 - `text_size`

Closes #1
jtheoof added a commit that referenced this issue Jan 13, 2020
@jtheoof
feat(config): have overridable defaults
105a610 
Defaults:

 - `save_dir`
 - `line_size``
 - `text_font`
 - `text_size`

Closes #1
@jtheoof jtheoof mentioned this issue Jan 13, 2020
Merged
jtheoof added a commit that referenced this issue Jan 13, 2020
@jtheoof
feat(config): have overridable defaults
44aeb34 
Defaults:

 - `save_dir`
 - `line_size`
 - `text_font`
 - `text_size`

Closes #1
jtheoof added a commit that referenced this issue Jan 13, 2020
@jtheoof
feat(config): have overridable defaults
f0d6b08 
Defaults:

 - `save_dir`
 - `line_size`
 - `text_font`
 - `text_size`

Closes #1
jtheoof added a commit that referenced this issue Jan 13, 2020
@jtheoof
feat(config): have overridable defaults
ef24851 
Defaults:

 - `save_dir`
 - `line_size`
 - `text_font`
 - `text_size`

Closes #1
@jtheoof
Copy link
Owner

jtheoof commented Jan 13, 2020

It's done for the configuration part, I'll tackle the more interesting part for you guys next week. See #2

@jtheoof
Copy link
Owner

jtheoof commented Jan 20, 2020

@Biont @scyt 🎉 check out option -o - in the man / readme. Happy piping.

@Biont
Copy link

Biont commented Jan 20, 2020

Thanks @jtheoof ! Works nicely on a first test. This is amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jtheoof jtheoof

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(config): have overridable defaults jtheoof/swappy
3 participants
@jtheoof @Biont @scyt