Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kubectl with gke-gcloud-auth-plugin, unbound variable #77

Merged
merged 1 commit into from
Jun 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -116,14 +116,6 @@ Below is the list of available components (as of version `342.0.0`):
└───────────────┴──────────────────────────────────────────────────────┴──────────────────────────┴──────────┘
```

# FAQ

```
~/.asdf/lib/commands/command-exec.bash: line 23: shim_args[@]: unbound variable
```

**This is expected** as `gcloud` requires a command. `asdf-gcloud` sets the Bash option for `nounset` variables which makes running `gcloud` without commands appear as an `asdf` error. You should always pass a command to `gcloud`.

# Contributing

Contributions of any kind welcome! See the [contributing guide](CONTRIBUTING.md).
Expand Down
2 changes: 1 addition & 1 deletion bin/exec-env
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash

set -euo pipefail
set -eo pipefail

current_script_dir="$(
cd -- "$(dirname "${BASH_SOURCE[0]}")" >/dev/null 2>&1
Expand Down
2 changes: 1 addition & 1 deletion lib/utils.bash
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash

set -euo pipefail
set -eo pipefail

# START Logging
function log_failure_and_exit() {
Expand Down