Rxns with layers #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattldawson
requested changes
Jun 21, 2024
src/aero_rep_data.F90
Outdated
|
|
||
| !> List of phase ids | ||
| integer(kind=i_kind), allocatable :: phase_ids(:) | ||
| !> Aerosol representation data | ||
| class(aero_rep_data_t), intent(in) :: this | ||
| !> Aerosol phase name | ||
| character(len=*), intent(in) :: phase_name | ||
| !> Indicates if aerosol phase is at the surface of particle | ||
| logical, intent(in), optional :: is_at_surface | ||
| logical, allocatable :: aero_is_at_surf(:) |
src/aero_rep_data.F90
Outdated
Comment on lines
523
to
524
| end if | ||
| end do | ||
| if (.not. is_at_surface) then |
There was a problem hiding this comment.
This could just be else
src/aero_rep_data.F90
Outdated
Comment on lines
517
to
518
| if (this%aero_phase(i_phase)%val%name().eq. phase_name .and. & | ||
| aero_is_at_surf(i_phase) .eqv. .true.) then |
There was a problem hiding this comment.
Suggested change
| if (this%aero_phase(i_phase)%val%name().eq. phase_name .and. & | |
| aero_is_at_surf(i_phase) .eqv. .true.) then | |
| if (this%aero_phase(i_phase)%val%name().eq. phase_name .and. & | |
| aero_is_at_surf(i_phase)) then |
src/aero_rep_data.F90
Outdated
Comment on lines
527
to
528
| if (this%aero_phase(i_phase)%val%name().eq. phase_name .and. & | ||
| aero_is_at_surf(i_phase) .eqv. .false.) then |
There was a problem hiding this comment.
Suggested change
| if (this%aero_phase(i_phase)%val%name().eq. phase_name .and. & | |
| aero_is_at_surf(i_phase) .eqv. .false.) then | |
| if (this%aero_phase(i_phase)%val%name().eq. phase_name .and. & | |
| .not. aero_is_at_surf(i_phase)) then |
| @@ -374,6 +373,7 @@ subroutine initialize(this, chem_spec_data, aero_rep, n_cells) | |||
|
|
|||
| ! Save the index of the gas-phase species in the state variable array | |||
| GAS_SPEC_ = chem_spec_data%gas_state_id(gas_spec_name) | |||
| print *, GAS_SPEC_ | |||
There was a problem hiding this comment.
please remove debug code
jcurtis2
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added is_at_surface flag to indicate if phase exists in the surface layer of particle