Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): method 'where' apply 2 times selection function #962

Merged
merged 1 commit into from
Jul 22, 2021
Merged

fix(table): method 'where' apply 2 times selection function #962

merged 1 commit into from
Jul 22, 2021

Conversation

zhiwen95
Copy link
Contributor

@zhiwen95 zhiwen95 commented Jul 21, 2021

Thanks for contributing.

Description

fix(table): method 'where' apply 2 times selection function

Testing

Did you add a unit test?

No

@lwhite1
Copy link
Collaborator

lwhite1 commented Jul 21, 2021

Hi, Could you update the description with the number for the issue that you're addressing here?

Also, i will ask you to provide a test that shows the fix works, unless that's very difficult to do for some reason.

thanks.

@lwhite1
Copy link
Collaborator

lwhite1 commented Jul 22, 2021

yeah, never mind the prior comments. The change is self-explanatory

@lwhite1 lwhite1 merged commit aedd7dd into jtablesaw:master Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants