Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize CSV escaping #772

Merged
merged 1 commit into from
Apr 5, 2020
Merged

Standardize CSV escaping #772

merged 1 commit into from
Apr 5, 2020

Conversation

benmccann
Copy link
Collaborator

@benmccann benmccann commented Mar 3, 2020 •
edited
Loading

Thanks for contributing.

Description

Closes #771

Made CsvReadOptions and CsvWriteOptions use the same defaults. The options were nullable in CsvReadOptions and fell back to the univocity defaults whereas CsvWriteOptions was non-nullable and specified its own non-standard defaults. I changed CsvWriteOptions to be nullable and fallback to the univocity defaults.

Testing

Added a unit test

@benmccann benmccann requested a review from lwhite1 March 3, 2020 16:44
@benmccann benmccann mentioned this pull request Mar 3, 2020
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

@benmccann benmccann merged commit 51883b5 into master Apr 5, 2020
@lwhite1 lwhite1 deleted the standardize-escaping branch July 13, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwhite1 lwhite1 Awaiting requested review from lwhite1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent handling of quotes when reading / writing CSV
1 participant
@benmccann