Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sheet name #758

Merged
merged 7 commits into from
Feb 17, 2020
Merged

Sheet name #758

merged 7 commits into from
Feb 17, 2020

Conversation

R1j1t
Copy link
Contributor

@R1j1t R1j1t commented Feb 14, 2020

Thanks for contributing.

Description

closes #756

This commit stores the sheet name as part of Table.name(). Following are the TODO

  • add sheet selection by name

Edit:
Removed sheet selection by name for this PR

Testing

Did you add a unit test?
I added a test to check name in Table

@R1j1t R1j1t requested a review from benmccann February 14, 2020 20:05
@benmccann benmccann merged commit a319203 into jtablesaw:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storing/Using sheet name when reading excel
2 participants