fixes ArrayIndexOutOfBoundsException when reading CSV file #658 #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trims headers consistently.
|
@lwhite1 Travis is failing |
benmccann
reviewed
Sep 5, 2019
| @@ -62,6 +62,7 @@ private String cleanName(String name) { | |||
| String[] headerNames = parser.parseNext(); | |||
| // work around issue where Univocity returns null if a column has no header. | |||
| for (int i = 0; i < headerNames.length; i++) { | |||
| headerNames[i] = headerNames[i].trim(); | |||
There was a problem hiding this comment.
It looks like this could cause an NPE since the next line checks if headerNames[i] == null
There was a problem hiding this comment.
I'll move the call
@lwhite1 Travis is failing
It's the log-length thing again, which I've "fixed" several times by suppressing various kinds of output. I guess we're limited to somewhere 3000-3500 lines of output now or some such. This time the extra output is from issues related to documentation.
With the sub-projects it seems we will run into this a lot. I'd like to suppress all logging except errors. Is that possible?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trims headers consistently.
Thanks for contributing.
Description
Trim headers consistently
Testing
Did you add a unit test? Yes