Column creation from streams

[benmccann]

Thanks for contributing.

• Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1

Description

I use Java 8 streams a lot. This makes column creation a bit easier

[lwhite1]

This is great, @benmccann. Would you mind adding support for floats and shorts?

[benmccann]

The reason I didn't add support for floats and shorts is that the Java Stream API only supports map to object, int, long, and double. I suppose for float I could take a DoubleStream and for short I could take an IntStream, but I wasn't sure if it was worth adding that or not

[lwhite1]

Oh right. That was kinda half-assed of them. I think it would be better to either use larger types, or object types (e.g. Stream<Float>) than to leave holes in our API.

…

On Sun, Aug 25, 2019 at 12:35 PM Ben McCann ***@***.***> wrote: The reason I didn't add support for floats and shorts is that the Java Stream API only supports map to object, int, long, and double. I suppose for float I could take a DoubleStream and for short I could take an IntStream, but I wasn't sure if it was worth adding that or not — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#634?email_source=notifications&email_token=AA2FPARZMGOELNGKDHGSYI3QGKYF3A5CNFSM4IPH5CP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5CW5XA#issuecomment-524644060>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA2FPAQYZMYQVDTYJCAX62LQGKYF3ANCNFSM4IPH5CPQ> .

[benmccann]

Ok. I've updated it to use Stream<Float>, etc.