Issue 479 template customization

[hallvard]

property.

Thanks for contributing.

• Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1

Description

Modified the template to support setting location of plotly js library, and Page and PageBuilder accordingly.

Testing

There are tests for both cases, the default and custom cases.

[hallvard]

The test succeeds when run locally using mvn clean test. jsplot defines the following dependency on junit:

        <dependency>
            <groupId>junit</groupId>
            <artifactId>junit</artifactId>
            <scope>test</scope>
        </dependency>

[benmccann]

Not anymore: https://github.com/jtablesaw/tablesaw/blob/master/jsplot/pom.xml#L65

We just upgraded to junit 5. Can you rebase against master?

[hallvard]

Hm, for some reason I don't get the changes, I'm told my upstream/master branch pointing to https://github.com/jtablesaw/tablesaw.git is up-to-date and the last commit I see is "Use static imports for junit asserts"

[hallvard]

Strange, when I turned off VPN I suddenly could fetch the latest changes.

[hallvard]

I use Assertions.assertTrue, isn't that good enough?

[benmccann]

Perhaps it doesn't have great support for junit 5 yet. Everywhere else we statically import assertTrue and I'm guessing that makes it happier. Can you try that?

[benmccann]

Could we remove this since it's unused and make plotlyJsLocation final?

[hallvard]

Of course, with a builder it is nonsense.

[lwhite1]

@hallvard i take it you decided against setting a loader in the builders. Is this good to go then?

[hallvard]

I thought about several designs, one involved a global (singleton) TemplateManager that configured the engine and loader and that had the setTemplateLocations method. But I couldn't come up with other reasons for exposing the engine and loader than this method, so I decided on just introducing the method as a start. We can still keep the method if we need to introduce a (replaceable) singleton later. I haven't tried the method it in Eclipse, yet, but will do it now.

[hallvard]

I seemed to work as expected, I could use a different template located in the Eclipse workbench instead of the jsplot jar!