Name to lowercase in renameDuplicateColumnHeaders #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1ny1998
changed the title
ccleva
added a commit
to tlabs-data/tablesaw
that referenced
this pull request
Dec 15, 2024
ccleva
pushed a commit
to tlabs-data/tablesaw
that referenced
this pull request
Dec 15, 2024
(cherry picked from commit a6d644d)
1 task
ccleva
added a commit
to tlabs-data/tablesaw
that referenced
this pull request
Dec 15, 2024
ccleva
pushed a commit
to tlabs-data/tablesaw
that referenced
this pull request
Dec 15, 2024
(cherry picked from commit a6d644d)
|
Hi @s1ny1998. A fix based on your code is available in the new maintenance release from the maintenance fork. See this discussion for details. |
ccleva
added a commit
to tlabs-data/tablesaw
that referenced
this pull request
Jan 3, 2025
benmccann
pushed a commit
that referenced
this pull request
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
renameDuplicateColumnHeaders when allowDuplicateColumnNames is true is case sensitive which causes validateColumn(final Column<?> newColumn) to fail and throw IllegalArgumentException.
What was changed
Used toLowerCase while using HashMap.
Also thought of using treeMap, but get() in treeMap has timecomplexity of O(log(n))
Did you add a unit test?
No