replaced the implementation of Table method dropDuplicateRows() with … #1058
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…one that uses less memory
Thanks for contributing.
Description
The method dropDuplicateRows was very inefficient in its use of memory. There was, by the end of the method:
Plus, the comparison method to test equality value-by-value used a generic method that auto boxed all the primitive values.
This was replaced by a method that computes a hash function for the rows which is used to test for equality, eliminating the need for the sorted table copy. Unfortunately, the auto boxing equality test remains at least for now, however. it is only called when duplicate rows are encountered, rather than for every row in the table.
Testing
Did you add a unit test?
yes