Update moneyball tutorial #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only reference to where the baseball.csv file is located is the online course. You have to sign up, etc in order to access that location. Seeing as the same file is in the tablesaw repo already, I provided a link in the tutorial for easy download.
Update to new tablesaw syntax.
Some tabs were inserted during copy/paste
Replace all blank space in url with safety character %20 to ensure images load properly.
Added links to tablesaw dependencies to make this a bit more beginner-friendly.
|
Thanks very much, @jbsooter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing.
Description
First time contributor here. I was evaluating Tablesaw + Smile for use in a java-based course, along the way I realized that the Moneyball tutorial syntax was out of date.
What was changed:
(1) Code snippets were updated to the newer/streamlined tablesaw syntax
(2) The section on adding the smile dependency was updated to include the gradle syntax, as well as a note on the need to have the tablesaw-core and tablesaw-jsplot dependancies with the relevant mvnrepository links.
(3) Added a link to baseball.csv, as it is already in the tablesaw repo and was difficult to get from the linked online course.
(4) Replaced " " in image URLs with %20 so that they would render without issue.
I have tested the updated tutorial thoroughly and verified the outputs vs the old version.
Testing
Did you add a unit test?
N/A