Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #3596

Closed
wants to merge 1 commit into from
Closed

Conversation

CaptThomas
Copy link

Hey reviewers, thanks for a great tool. This PR is designed to fix GHSA-c2qf-rxjj-qqgw. I tested this locally using Windows 11 x64 using node v20.3.1 and npm 9.7.2 and it worked as expected.

@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Merging #3596 (bd6f6e2) into master (ae64aa8) will decrease coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3596      +/-   ##
==========================================
- Coverage   97.61%   97.44%   -0.18%     
==========================================
  Files         132      132              
  Lines        9280     9280              
  Branches     3391     3391              
==========================================
- Hits         9059     9043      -16     
- Misses        221      237      +16     

see 1 file with indirect coverage changes

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, it would be a breaking change.

@ljharb
Copy link
Member

ljharb commented Jul 3, 2023

It’s not a vulnerability here - like most transitive dep CVEs, it’s a false positive - and we can’t upgrade because v7 drops support for engines we need to support. Duplicate of #3589.

@ljharb ljharb closed this Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants