Fix style-prop-object false positive on computed properties (fixes #820)

jsx-eslint · Sep 15, 2016 · a41ca47 · a41ca47
1 parent a2a3de1
commit a41ca47
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/rules/style-prop-object.js b/lib/rules/style-prop-object.js
@@ -48,7 +48,7 @@ module.exports = {
         ) {
           if (node.arguments[1].type === 'ObjectExpression') {
             var style = node.arguments[1].properties.find(function(property) {
-              return property.key.name === 'style';
+              return property.key.name === 'style' && !property.computed;
             });
             if (style) {
               if (style.value.type === 'Identifier') {

diff --git a/tests/lib/rules/style-prop-object.js b/tests/lib/rules/style-prop-object.js
@@ -106,6 +106,14 @@ ruleTester.run('style-prop-object', rule, {
     {
       code: '<div style></div>',
       parserOptions: parserOptions
+    },
+    {
+      code: [
+        'React.createElement(MyCustomElem, {',
+        '  [style]: true',
+        '}, \'My custom Elem\')'
+      ].join('\n'),
+      parserOptions: parserOptions
     }
   ],
   invalid: [